samples: subsys: usb: webusb: Fix Win10 detection #59758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxd-nordic
force-pushed
the
webusb-win10-detection
branch
2 times, most recently
from
789ee76
to
36616c5
Compare
jfischer-no
requested changes
Jun 28, 2023
maxd-nordic
force-pushed
the
webusb-win10-detection
branch
from
36616c5
to
ac97f5d
Compare
maxd-nordic
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
tmon-nordic
reviewed
Jul 4, 2023
| .wLength = sizeof(struct ms_os_20_guids_property_desc), | ||
| .wDescriptorType = MS_OS_20_FEATURE_REG_PROPERTY, | ||
| .wPropertyDataType = MS_OS_20_PROPERTY_DATA_REG_MULTI_SZ, | ||
| .wPropertyNameLength = 42, |
There was a problem hiding this comment.
I wish zephyr had sizeof_field() macro like Linux kernel does.
tmon-nordic
previously approved these changes
Jul 4, 2023
jfischer-no
requested changes
Jul 6, 2023
maxd-nordic
force-pushed
the
webusb-win10-detection
branch
from
ac97f5d
to
f3be566
Compare
maxd-nordic
force-pushed
the
webusb-win10-detection
branch
2 times, most recently
from
e420eb5
to
e0b6d95
Compare
jfischer-no
reviewed
Jul 6, 2023
This patch refactors the usage of MS OS 2.0 descriptors in the WebUSB sample. The function subset header was removed since it is not allowed for non-composite devices. Also, a new random GUID was added for automatic driver installation. Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
maxd-nordic
force-pushed
the
webusb-win10-detection
branch
from
e0b6d95
to
675c7e0
Compare
jfischer-no
approved these changes
Jul 7, 2023
tmon-nordic
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the usage of MS OS 2.0 descriptors in the WebUSB sample. The function subset header was removed since it is not allowed for non-composite devices.
Also, a new random GUID was added for automatic driver installation.