Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers serial native ptty: Split in top and bottom #60053

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

aescolar
Copy link
Member

@aescolar aescolar commented Jul 5, 2023

Split the native ptty serial driver in a top and bottom to enable using it with embedded libCs when building targeting the native_sim boards

This is mostly a plain refactoring exercise, where code is moved.
Apart from that an old warning which is not applicable anymore was removed (when the uart is connected to the process invoking shell, as this is well supported now).

@zephyrbot zephyrbot added area: native port Host native arch port (native_sim) area: UART Universal Asynchronous Receiver-Transmitter labels Jul 5, 2023
@zephyrbot zephyrbot requested a review from dcpleung July 5, 2023 15:13
@aescolar aescolar force-pushed the native_ptty branch 2 times, most recently from 67f7069 to dfe1ca6 Compare July 6, 2023 12:16
Split the native ptty serial driver in a top and bottom
to enable using it with embedded libCs.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Copy link
Contributor

@ElvarT ElvarT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine with all config variations and runs as expected.
Just like the other PRs in this series, it is just moved code without logical changes.
So good.

@carlescufi carlescufi merged commit 1842c60 into zephyrproject-rtos:main Jul 10, 2023
19 checks passed
@aescolar aescolar deleted the native_ptty branch July 10, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: native port Host native arch port (native_sim) area: UART Universal Asynchronous Receiver-Transmitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants