Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: subsys: usb cdc acm composite with mini nb of USB EndPoints #60077

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Jul 6, 2023

The stm32f207 and stm32f429 target boards only have 4 bidir EP on the USB FS node
This is not enough to run the sample: simply exclude those 2 target platforms

Signed-off-by: Francois Ramu francois.ramu@st.com

@FRASTM FRASTM requested a review from jfischer-no as a code owner July 6, 2023 08:51
@zephyrbot zephyrbot added the area: USB Universal Serial Bus label Jul 6, 2023
@FRASTM
Copy link
Collaborator Author

FRASTM commented Jul 6, 2023

Filtering the USB controller in the sample.yaml
filter: dt_prop("num-bidir-endpoints") > 4
is not a valid syntax

@tmon-nordic
Copy link
Contributor

Filtering the USB controller in the sample.yaml
filter: dt_prop("num-bidir-endpoints") > 4
is not a valid syntax

@PerMac @gopiotr Could you please take a look? The problem with current PR is that excluding certain platforms is not going to scale. The better approach would be to have generic filter to not run the sample on targets that do not have the minimum number of endpoints.

The stm32f207 and stm32f429 target boards only have 4 bidir EP
on the USB FS node. This is not enough to run the sample:
simply exclude those 2 target platforms

Signed-off-by: Francois Ramu <francois.ramu@st.com>
@gopiotr
Copy link
Collaborator

gopiotr commented Jul 6, 2023

Filtering the USB controller in the sample.yaml
filter: dt_prop("num-bidir-endpoints") > 4
is not a valid syntax

@PerMac @gopiotr Could you please take a look? The problem with current PR is that excluding certain platforms is not going to scale. The better approach would be to have generic filter to not run the sample on targets that do not have the minimum number of endpoints.

@tmon-nordic - yes, you are right that this would be valuable to make it possible to limit platform scope by this expression. I take quick look at what were already implemented in Twister and unfortunately dt_prop(...) expression is not handled :( I analyzed it and it won't be that easy to add it quickly and it requires more work. If this functionality is very important to you, please create issue for this and we will consider when we will be able to deliver it.

At this moment only following dt_ expressions are available in Twister's filter option:

  1. dt_compat_enabled
  2. dt_alias_exists
  3. dt_enabled_alias_with_parent_compat
  4. dt_label_with_parent_compat_enabled
  5. dt_chosen_enabled
  6. dt_nodelabel_enabled

https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/pylib/twister/expr_parser.py#L227-L301

So, if you are not able to replace dt_prop(...) by any of above expression (or maybe some KConfig option), then at this moment platform_exclude is only available solution.

@carlescufi carlescufi merged commit f94fd8e into zephyrproject-rtos:main Jul 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: USB Universal Serial Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants