Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctf tracing: native/host backend: Refactor to support embedded C libraries #60104

Merged
merged 1 commit into from
Jul 13, 2023
Merged

ctf tracing: native/host backend: Refactor to support embedded C libraries #60104

merged 1 commit into from
Jul 13, 2023

Conversation

aescolar
Copy link
Member

@aescolar aescolar commented Jul 6, 2023 •
edited
Loading

Split this tracing backend in a top and bottom to enable building it with embedded libCs with the native simulator.

@aescolar aescolar requested a review from nashif as a code owner July 6, 2023 14:00
@aescolar aescolar mentioned this pull request Jul 6, 2023
Open
13 tasks
@aescolar aescolar requested a review from mped-oticon July 6, 2023 14:01
@zephyrbot zephyrbot added area: Tracing Tracing area: native port Host native arch port (native_sim) labels Jul 6, 2023
@zephyrbot zephyrbot requested a review from teburd July 6, 2023 14:01
mped-oticon
mped-oticon reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@mped-oticon mped-oticon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nitpickery and a question.

subsys/tracing/CMakeLists.txt Show resolved Hide resolved
subsys/tracing/tracing_backend_posix_bottom.c Outdated Show resolved Hide resolved
subsys/tracing/tracing_backend_posix_bottom.h Outdated Show resolved Hide resolved
@aescolar
ctf tracing: native/host backend: Refactor to support embedded C libr…
8562817 
…aries

Split this tracing backend in a top and bottom to enable
building it with embedded libCs with the native simulator.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar aescolar requested a review from mped-oticon July 6, 2023 15:27
@aescolar aescolar requested a review from daor-oti July 6, 2023 15:37
ElvarT
ElvarT approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@ElvarT ElvarT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, and code is fine

@nashif nashif merged commit 9be7b59 into zephyrproject-rtos:main Jul 13, 2023
@aescolar aescolar deleted the natsim_tracing branch July 18, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daor-oti daor-oti daor-oti approved these changes

@ElvarT ElvarT ElvarT approved these changes

@mped-oticon mped-oticon mped-oticon approved these changes

@nashif nashif nashif approved these changes

@teburd teburd Awaiting requested review from teburd

Assignees

@nashif nashif

Labels
area: native port Host native arch port (native_sim) area: Tracing Tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aescolar @nashif @mped-oticon @ElvarT @daor-oti @zephyrbot