Bluetooth: audio: ascs: Fix invalid memset of QoS parameters #60107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes invalid memset of QoS parameters that may happen if Config Qos operation is requested on ASE in QoS Configured state. In such case if the requested parameters have been rejected, the ASE QoS parameters shall remain unchanged (were memset instead). Otherwise, the stack shall send QoS Configured state notification with cleaned up parameters (all zero's) which was not done. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
MariuszSkamra
requested review from
jhedberg,
Vudentz,
Thalley and
sjanc
as code owners
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa,
larsgk and
szymon-czapracki
Thalley
approved these changes
Jul 10, 2023
Comment on lines
+1836
to
+1842
| cqos.interval = sys_get_le24(qos->interval); | ||
| cqos.framing = qos->framing; | ||
| cqos.phy = qos->phy; | ||
| cqos.sdu = sys_le16_to_cpu(qos->sdu); | ||
| cqos.rtn = qos->rtn; | ||
| cqos.latency = sys_le16_to_cpu(qos->latency); | ||
| cqos.pd = sys_get_le24(qos->pd); |
There was a problem hiding this comment.
We could consider pulling these values directly from buf instead of doing qos = net_buf_simple_pull_mem(buf, sizeof(*qos)); followed by these assignments.
larsgk
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes invalid memset of QoS parameters that may happen if Config Qos operation is requested on ASE in QoS Configured state. In such case if the requested parameters have been rejected, the ASE QoS parameters shall remain unchanged (were memset instead). Otherwise, the stack shall send QoS Configured state notification with cleaned up parameters (all zero's) which was not done.