drivers: lpadc: fix ADC command chaining #60111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading multiple ADC channel in parallel, an ADC command chain will be build. This is similar to a linked list, as every command references the next command. Before this patch every ADC command after the first, would always reference this initial command. So that during execution only two commands (the last and first) would be executed which resulted in readout of only two analog values. As Zephyr expected more to come in, the `read_adc` function would block endlessly. The patch fixes the behaviour and allows a correct chain to build up. Signed-off-by: Elisabeth Friedrich <auxsys@flowerpot.me>
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
manuargue,
mmahadevan108 and
yvanderv
danieldegrasse
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks for the fix, was able to reproduce this issue. I opened #60276 which should hopefully catch regressions like this in the future.
decsny
approved these changes
Jul 11, 2023
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading multiple ADC channel in parallel, an ADC command chain will be build. This is similar to a linked list, as every command references the next command.
Before this patch every ADC command after the first, would always reference this initial command. So that during execution only two commands (the last and first) would be executed which resulted in readout of only two analog values. As Zephyr expected more to come in, the
read_adcfunction would block endlessly.The patch fixes the behaviour and allows a correct chain to build up, fixing the regression that has been introduced by
e587047