emul: spi: SPI_EMUL_INIT(n) hard-coded to instance #0 #60118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SPI_EMUL_INIT(n)` macro used to instantiate SPI bus emulators builds an array of SPI devices attached to the bus, but always checks instance #0 of the bus and not `n`. This makes multiple instances of an emulated SPI bus unusable and popualtes them all with bus 0's devices. Change the `0` to `n`, which matches how the I2C bus emulator does it. Signed-off-by: Tristan Honscheid <honscheid@google.com>
keith-zephyr
approved these changes
Jul 6, 2023
fabiobaltieri
approved these changes
Jul 6, 2023
fabiobaltieri
added
the
Trivial
The commit message is valid. See 39cfc52 Also note that the compliance checks verify the commit message format. |
There is a misspelling of word "populates" with "popualtes" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SPI_EMUL_INIT(n)macro used to instantiate SPI bus emulators builds an array of SPI devices attached to the bus, but always checks instance #0 of the bus and notn. This makes multiple instances of an emulated SPI bus unusable and popualtes them all with bus 0's devices.Change the
0ton, which matches how the I2C bus emulator does it.