Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete set of changes to enable picolibc by default #60124

Closed

Conversation

keith-packard
Copy link
Collaborator

@keith-packard keith-packard commented Jul 6, 2023

This series incorporates all of the patches necessary to switch to using picolibc by default. All of them are also available as separate PRs, this PR is designed to validate that the full set works as desired.

This is intended to have the changes mentioned in #49922

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 6, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
sof zephyrproject-rtos/sof@ffbf9c2 (zephyr-20230807) zephyrproject-rtos/sof#28 zephyrproject-rtos/sof#28/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please go ahead and merge zephyrproject-rtos/sof#28

This test fails when icount is disabled, so enable it

See 7bdc621 which disabled icount by
default for this platform.

Signed-off-by: Keith Packard <keithp@keithp.com>
This switches the default C library to picolibc for all targets which
support it.

Signed-off-by: Keith Packard <keithp@keithp.com>
With picolibc being the default C library, we need to explicitly include
testing against the minimal C library for kernel components.

Signed-off-by: Keith Packard <keithp@keithp.com>
@keith-packard
Copy link
Collaborator Author

This PR is no longer necessary as #57340 works with no additional patches! I'm going to close it; please feel free to review #57340 if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants