-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: interrupt-controller: Add TI VIM Interrupt Controller support #60856
drivers: interrupt-controller: Add TI VIM Interrupt Controller support #60856
Conversation
e953584
to
036d232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have devicetree binding match https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/tree/Bindings/interrupt-controller/arm,vic.yaml
@galak I have added compatible property in arm,vim.yaml for devicetree binding match. Am I missing something? |
036d232
to
8dd5e19
Compare
8dd5e19
to
83bd162
Compare
83bd162
to
b419778
Compare
b419778
to
28a98e5
Compare
@galak Does the current binding look okay to you now? when this PR was created initially, the naming, compatible were chosen in a confusing manner which created the impression that the support being added here was for standard ARM Vectored Interrupt Controller while the support being added here is for a TI specific interrupt controller (VIM) which is R5F VIC port compatible but not equivalent. Also the
But in our case there is support for configuration for interrupt sources (flags, priority .etc). Please let know if changes needs to be made. |
@galak , can you please let know if this is still relevant/if not can you remove the change requested label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - this comment was left in pending for a while.
Add TI VIM (Vectored Interrupt Manager) interrupt controller support. VIM is a TI specific custom interrupt controller for ARM cores. In J721E soc, VIM aggregates interrupts to Cortex R5 cores. TRM for J721e https://www.ti.com/lit/zip/spruil1 File: spruil1c.pdf VIM: section 6.3.3.6 Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
5a00895
28a98e5
to
5a00895
Compare
Add VIM (Vectored Interrupt Manager) interrupt controller support
TRM for J721e https://www.ti.com/lit/zip/spruil1
File: spruil1c.pdf
VIM: section 6.3.3.6
BeagleBone AI_64 https://beagleboard.org/ai-64