-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the DT_MEMORY_ATTR_
defines
#60874
Add the DT_MEMORY_ATTR_
defines
#60874
Conversation
Add a dt-bindings header file to be able to easily match in C code the YAML / DT enum. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Instead of relying on numerical values only. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
DT_MEMORY_ATTR_RAM, | ||
DT_MEMORY_ATTR_RAM_NOCACHE, | ||
DT_MEMORY_ATTR_FLASH, | ||
DT_MEMORY_ATTR_PPB, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ppb? maybe add a comment, since I've got no clue what PPB is ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galak replying here also for the other comment.
Agree, naming and description is a big issue here. @manuargue will be taking care of that soon, see #60049 (review) and #60049 (comment) but I think we are forced to live with it for a little while, but cleaning up is already planned I swear :)
DT_MEMORY_ATTR_FLASH, | ||
DT_MEMORY_ATTR_PPB, | ||
DT_MEMORY_ATTR_IO, | ||
DT_MEMORY_ATTR_EXTMEM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is extmem suppose to mean? How does it differ from RAM?
Just adding the |
Keep the DNM, working on a better version of this. |
Bridge the usual disconnection between C code and DT / YAML file when using enums by introducing a new dt-bindings header file.