posix: signal: include_next to get the libc signal() decl #60948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
include-next-for-signal
branch
6 times, most recently
from
f1fe0bb
to
d13e68c
Compare
cfriedt
added
area: Tests
|
Unrelated errors are unrelated. |
ycsin
previously approved these changes
Jul 30, 2023
cfriedt
force-pushed
the
include-next-for-signal
branch
from
d13e68c
to
873ba38
Compare
cfriedt
force-pushed
the
include-next-for-signal
branch
4 times, most recently
from
a75a3f0
to
c039128
Compare
|
This is getting annoying. I might trim it down to the bare essentials. |
We don't actually implement signal() in Zephyr, but some users require the declaration. Additionally, typedef sig_atomic_t since it is part of ISO. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
Some declarations were not visible when including the POSIX version of `<time.h>` or `<signal.h>`. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
We don't actually implement signal() in Zephyr, but some users require the declaration. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
The `signal()` function was part of ANSI-C and predates POSIX, so it should be visible (even if it completely unsupported in Zephyr currently). The `sig_atomic_t` type is part of ISO C, regardless of whether POSIX is enabled. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
force-pushed
the
include-next-for-signal
branch
from
c039128
to
d566e1f
Compare
|
Closing in favour of the other signal.h PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Coding Guidellines issue is a false positive
Although the ANSI C version of signal() is not yet supported in Zephyr, because Zephyr does not use process-wide signals, some users rely on its declaration.
Include the libc version of signal.h when POSIX signals are not configured.
Also fixed some inadvertent typing to be more compliant with the spec.
Fixes #56294