-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: has: Ensure that notifications are sent #61980
Bluetooth: has: Ensure that notifications are sent #61980
Commits on Oct 17, 2023
-
Bluetooth: audio: has: Fix checking wrong flag
This fixes testing and clearing features flag. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 81d5dad - Browse repository at this point
Copy the full SHA 81d5dadView commit details -
Bluetooth: audio: has: Fix indentation
This fixes code indentation. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 52950ea - Browse repository at this point
Copy the full SHA 52950eaView commit details -
Bluetooth: audio: has: Don't revert features value on error
This removes revering the features value back to previous state if work submission failes. Even if it fails it indicates an internal sysworkq issue, so even retry won't help. The client can read the features value anyway, thus it's sane to just log an error in such case. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for b515f12 - Browse repository at this point
Copy the full SHA b515f12View commit details -
Bluetooth: audio: has: Fix sending notifications on reconnect
This fixes missing setting of FLAG_CONTROL_POINT_NOTIFY flag that indicate whether submit control_point_work. In case the there are more indications/notifications to sent (is_last flag is unset), the FLAG_CONTROL_POINT_NOTIFY shall be set to resubmit control_point_work. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for a5c9e9b - Browse repository at this point
Copy the full SHA a5c9e9bView commit details -
Bluetooth: audio: has: Factor out set_preset_availability function
This moves common code to set_preset_availability function to be called from bt_has_preset_available and bt_has_preset_unavailable. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 68cd2db - Browse repository at this point
Copy the full SHA 68cd2dbView commit details -
tests: Bluetooth: has: Add test Preset Changed Offline Behavior
Verify that a HAS Server IUT sends changed characteristic notifications or indications when the Lower Tester reconnects. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for a3e4cca - Browse repository at this point
Copy the full SHA a3e4ccaView commit details
Commits on Oct 18, 2023
-
Bluetooth: audio: has: Defer notifications to sysworkq
Defer sending the features, active index, preset list and preset read response to sysworkq and retry sending in case failed due to buffers not available at the moment. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 76fe66c - Browse repository at this point
Copy the full SHA 76fe66cView commit details -
Bluetooth: audio: has: Refactor preset list to single-linked list
This refactors the preset list to use sys_slist API. There have been various issues seen while iterating presets, thus it's more save to use well-defined and tested sys_slist API. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 9c41221 - Browse repository at this point
Copy the full SHA 9c41221View commit details -
Bluetooth: has: Factor out bonded client persistent data
Some of the data shall be persistent across connections to bonded clients. This includes notidication state flags that are used to determine whether notify bonded client after reconnection. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 82dea82 - Browse repository at this point
Copy the full SHA 82dea82View commit details -
Bluetooth: has: Fix preset list notifications after reconnection
This fixes sending proper Preset List notifications after reconnection. The issue was observed when the last preset known to the client has been removed. As we do not hold the information about the deleted presets, we need to use Generic Update procedure to: 1. Notify the presets that have been removed in range (PrevIndex = current_preset_last, Index=previous_preset_last) 2. Notify deletion of preset Index=previous_preset_last. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 00c6dd4 - Browse repository at this point
Copy the full SHA 00c6dd4View commit details -
Bluetooth: audio: has: Fix missing memset of parameters
This fixes missing memset of parameters used for indications and/or notifications. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 5c932a7 - Browse repository at this point
Copy the full SHA 5c932a7View commit details
Commits on Oct 19, 2023
-
Bluetooth: audio: has: Truncate Control Point notifications to ATT MTU
This will truncate ATT notifications/indications if exceed ATT MTU size. It is up to the client to exchange MTU. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for e6a55ea - Browse repository at this point
Copy the full SHA e6a55eaView commit details -
Bluetooth: audio: has: Remove include of conn_internal header
This makes use of bt_conn_get_info function to access the conn address. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 71574e8 - Browse repository at this point
Copy the full SHA 71574e8View commit details -
Bluetooth: audio: has: Minor logging improvement
This adds more logs for debugging purposes. Signed-off-by: Mariusz Skamra <mariusz.skamra@codecoup.pl>
Configuration menu - View commit details
-
Copy full SHA for 46f74aa - Browse repository at this point
Copy the full SHA 46f74aaView commit details