tests: bsim: Bluetooth: BAP Broadcast update to 2 bis #62511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
3 times, most recently
from
cb9ee46
to
52e9b71
Compare
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
from
52e9b71
to
ff30376
Compare
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
3 times, most recently
from
7d2a664
to
91509e0
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa,
larsgk,
MariuszSkamra and
sjanc
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
from
91509e0
to
0165c0c
Compare
fredrikdanebjer
previously approved these changes
Dec 11, 2023
kruithofa
previously approved these changes
Dec 11, 2023
MariuszSkamra
previously approved these changes
Dec 11, 2023
|
@Thalley this needs a rebase |
Thalley
dismissed stale reviews from MariuszSkamra, kruithofa, and fredrikdanebjer
via
53e9a63
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
from
0165c0c
to
53e9a63
Compare
|
Rebased to solve merge conflicts |
MariuszSkamra
previously approved these changes
Dec 14, 2023
|
@kruithofa @fredrikdanebjer Can you please re-review? |
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
from
53e9a63
to
699eecf
Compare
Update the bsim test for the BAP broadcast to use 2 bis. This tests a larger part of the code, and also verifies that we can send and receive on 2 BIS without any ISO errors. This requires the ADV interval to be a multiple of ISO interval - 10ms, so the advertising interval has been set to 80ms. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
broadcast_bsim_dual_bis
branch
from
699eecf
to
7779769
Compare
cvinayak
approved these changes
Jan 9, 2024
kruithofa
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the bsim test for the BAP broadcast to use 2 bis.
This tests a larger part of the code, and also verifies
that we can send and receive on 2 BIS without any ISO errors.
Fixes #59676