Add PWM pulse capture driver for S32K344 #62695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dat-NguyenDuy
requested review from
nashif,
manuargue and
tejlmand
as code owners
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
anangl,
bperseghetti,
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
henrikbrixandersen,
mmahadevan108,
PetervdPerk-NXP and
yvanderv
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
8cef7f9
to
e04e996
Compare
zephyrbot
added
manifest
manifest-hal_nxp
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
2 times, most recently
from
db01a08
to
69d2d42
Compare
manuargue
reviewed
Sep 20, 2023
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
69d2d42
to
6f499f6
Compare
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
2 times, most recently
from
3df256c
to
8f9d42f
Compare
|
The CI failures are due to #63238, you'll need to rebase once the fix is in |
manuargue
reviewed
Sep 28, 2023
There was a problem hiding this comment.
LGTM overall. @mmahadevan108 do you think we can get the HAL pr merged while we gather more feedback on this?
|
@Dat-NguyenDuy . Kindly rebase to pull in the HAL SHA |
|
@Dat-NguyenDuy , please also provided details on how this PR was tested. |
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
2 times, most recently
from
6e6b552
to
13e7c67
Compare
I rebased |
i tested with 13e7c67 |
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
13e7c67
to
a50acd0
Compare
|
Rebased to fix conflict. But there would have build fails because of this PR was merged in hal_nxp zephyrproject-rtos/hal_nxp#273. But unfortunately the one in zephyr is still under review #62755 |
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
a50acd0
to
ab64292
Compare
This enables and declares interrupt handlers for eMIOS, the handlers defined and implemented at HAL, the driver takes the name for each id from interrupt-names devicetree Signed-off-by: Dat Nguyen Duy <dat.nguyenduy@nxp.com>
This prepares support pwm capture APIs by extended current pwm shim driver but use a differrence hal component: - Introduce a Kconfig options that will be set when PWM pulse generation API is used, it is also used to select the hal component. Guarding current code inside this Kconfig option - Increase #pwm-cells to 3, flags is supported for PWM capture - Do not require duty-cycle and polarity be set in dt, PWM capture doesn't need it. - Rename emum value for pwm-mode to keep only key information - Add preprocessor in case no channel is configured for generate PWM output, to avoid warning when build Signed-off-by: Dat Nguyen Duy <dat.nguyenduy@nxp.com>
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
ab64292
to
7ef24c3
Compare
manuargue
previously approved these changes
Sep 29, 2023
|
@Dat-NguyenDuy , we have reverted the pinctlrl PR that. Can you please update your west.yml SHA. |
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
7ef24c3
to
722af2c
Compare
This introduces pwm capture shim driver for NXP S32 EMIOS, the driver uses SAIC mode that is supported for all channels, to capture the counter value on each edge for period/pulse measurement Signed-off-by: Dat Nguyen Duy <dat.nguyenduy@nxp.com>
Enable PWM loopback testing for mr_canhubk3 Signed-off-by: Dat Nguyen Duy <dat.nguyenduy@nxp.com>
Dat-NguyenDuy
force-pushed
the
s32k3-pwm-capture
branch
from
722af2c
to
6da8592
Compare
mmahadevan108
approved these changes
Sep 29, 2023
manuargue
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces PWM pulse capture driver over eMIOS peripheral for S32K344