nrf_bsim - changes towards having nrf53_bsim - part 2 #62706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aescolar
changed the title
aescolar
requested review from
nashif,
wopu-ot,
tejlmand,
galak and
nordicjm
as code owners
zephyrbot
added
area: Board/SoC configuration
platform: nRF
jori-nordic
previously approved these changes
Sep 18, 2023
anangl
previously approved these changes
Sep 19, 2023
Just like for the nrf52_bsim let's add helper kconfig symbols which can be used to identify we are running in a target that is compatible with the real HW but is not the real HW. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Also set the HAL variant appropriately when building for the new nrf53_bsim boards. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
force-pushed
the
nrfbsim_minors2
branch
from
c911750
to
d3eb984
Compare
anangl
approved these changes
Sep 19, 2023
|
Changed based on a suggestion from @anangl , as SOC_COMPATIBLE_NRF5340 was not really required. |
jori-nordic
approved these changes
Sep 20, 2023
carlescufi
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two more minor changes in preparation for the upcoming nrf53_bsim boards:
(Sending them as their own PR to avoid a massive PR)
nrf5x_bsim: Add helper kconfig symbols for simulated nrf5340
Just like for the nrf52_bsim let's add helper kconfig symbols
which can be used to identify we are running in a target that
is compatible with the real HW but is not the real HW.
hal nordic: cmake: Add support for nrf53_bsim boards
Also set the HAL variant appropriately when building for
the new nrf53_bsim boards.