posix: pthread: do not assert in pthread_exit() on k_thread #62733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `pthread_exit()` is called from a `k_thread`, then we would previously trigger an assertion. The problem with that, is that is POSIX is acting as a compatibility layer. Given that it is a reasonable expectation to have the calling thread exit or abort when calling `pthread_exit()`, lets do just that. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
added
bug
fabiobaltieri
approved these changes
Sep 16, 2023
dkalowsk
approved these changes
Sep 16, 2023
cfriedt
deleted the
issues/62732/posix-pthread-exit-on-non-pthread-asserts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
pthread_exit()is called from ak_thread, then we currently trigger an assertion. It is a reasonable expectation to have the calling thread exit or abort when callingpthread_exit(), so lets do just that, which mirrors the original behaviour.Detected when the C++ threads PR was rebased, as POSIX is acting as a compatibility layer.
Fixes #62732