Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: ish: Change aon linker snippet #62736

Closed
wants to merge 1 commit into from

Conversation

ceolin
Copy link
Member

@ceolin ceolin commented Sep 16, 2023

Do not include ish specific linker in the default
ia32 linker script. Instead, use snippets-sections snippet for that.

Do not include ish specific linker in the default
ia32 linker script. Instead, use snippets-sections snippet
for that.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
@zephyrbot zephyrbot added area: X86 x86 Architecture (32-bit) platform: X86 x86 and x86-64 platform: Intel ISH Intel Corporation, Integrated Sensor Hub labels Sep 16, 2023
@kwd-doodling
Copy link
Collaborator

@leifuzhao review first, make sure ISH PM isn't broken.

dcpleung
dcpleung previously approved these changes Sep 18, 2023
@kwd-doodling
Copy link
Collaborator

AON section must be put to the very begging of all sections.
this patch make ish PM broken.

@ceolin ceolin added the DNM This PR should not be merged (Do Not Merge) label Sep 25, 2023
@ceolin
Copy link
Member Author

ceolin commented Sep 25, 2023

Added DNM label so I can check it later.

@carlescufi carlescufi dismissed dcpleung’s stale review September 26, 2023 11:40

The merge-base changed after approval.

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 26, 2023
@github-actions github-actions bot closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: X86 x86 Architecture (32-bit) DNM This PR should not be merged (Do Not Merge) platform: Intel ISH Intel Corporation, Integrated Sensor Hub platform: X86 x86 and x86-64 Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants