fix: USB C vbus Kconfig #62740
Closed
fix: USB C vbus Kconfig #62740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The init priority and the logging module are used in both vbus and tcpc, hence I think it should be better located in the Kconfig file of the parent folder. Signed-off-by: Mark Kettner <mark@kettner.io>
this adds a sample application showing the usage of the usb_c vbus driver. Signed-off-by: Mark Kettner <mark@kettner.io>
| regulator that provides a fixed voltage to IO38 of the esp32 behind a voltage divider. In this | ||
| sample the voltage divider consists of 300k and 100k Ohms resistors. It will then print the measured | ||
| battery voltage to the console. If you take care to not power the device thru the usb port, you can | ||
| see how the battery voltage decreases over time, Thus indicating the current charging level. |
There was a problem hiding this comment.
I'm not sure what you mean by "indicates the current charging level". Your sample only prints the battery voltage. Without knowing the battery capacity and/or empty voltage, I'm not sure how one infers the charge level.
| Requirements | ||
| ************ | ||
|
|
||
| A charging regulator (e.g. MAX777) connected to a voltage divider to the |
There was a problem hiding this comment.
This sentence is incomplete.
| :goals: build flash | ||
| :compact: | ||
|
|
||
| To build for another board, change "qemu_x86" above to that board's name. |
There was a problem hiding this comment.
Suggested change
| To build for another board, change "qemu_x86" above to that board's name. | |
| To build for another board, change "esp32_devkitc_wrover" above to that board's name. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a minor problem I've noticed with the Kconfig of the USB C drivers.
You can use this driver https://github.com/zephyrproject-rtos/zephyr/tree/main/drivers/usb_c/vbus
standalone to measure the voltage from a charging regulator (e.g. https://www.analog.com/en/products/MAX77757.html ) which gives you a simple indication of the charging level of battery, as I've shown in the sample application in
sample/driver/vbatt. This sample is also very similar to the one from nrf but the battery measurement logic is done by the usb c vbus driver instead.However, the code from
drivers/usb_c/vbus/depends on symbols defined indrivers/usb_c/tcpc/Kconfig. Thus you could not create this simple sample without pulling in the usb typec port controller.