Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: migration-guide: add notes on SSD1306 Kconfig changes #62748

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

soburi
Copy link
Member

@soburi soburi commented Sep 17, 2023

Some SSD1306 Kconfig options replaced by dts to make able to configure per device.
Add the description how to migrate it.

@soburi
Copy link
Member Author

soburi commented Sep 17, 2023

@kartben

About this matter
#62625 (comment)

@kartben kartben added this to the v3.5.0 milestone Oct 2, 2023
fabiobaltieri
fabiobaltieri previously approved these changes Oct 3, 2023
@fabiobaltieri
Copy link
Member

@soburi hey this needs a rebase

@soburi
Copy link
Member Author

soburi commented Oct 3, 2023

@fabiobaltieri
Thanks for the notification.
I've updated it.

fabiobaltieri
fabiobaltieri previously approved these changes Oct 4, 2023
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some grammar/style changes -- sorry for the late review, and thanks for taking the time to document this!

doc/releases/migration-guide-3.5.rst Outdated Show resolved Hide resolved
Some SSD1306 Kconfig options replaced by dts to make able to
configure per device.
Add the description how to migrate it.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
@soburi
Copy link
Member Author

soburi commented Oct 8, 2023

@kartben
Thank you for the correction.
I reflected and pushed it again.

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soburi thank you!

@jhedberg jhedberg merged commit 73f45f6 into zephyrproject-rtos:main Oct 9, 2023
14 checks passed
@soburi soburi deleted the migration_guide_ssd1306 branch October 17, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants