[Backport v2.7-branch] can: rework the table lookup code in can_dlc_to_bytes #62773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the can_dlc_to_bytes table lookup code in a way that allow the compiler to guess the resulting output and somehow fix the build warning: zephyr/drivers/can/can_nxp_s32_canxl.c:757:9: warning: '__builtin___memcpy_chk' forming offset [16, 71] is out of the bounds [0, 16] of object 'frame' with type 'struct can_frame' [-Warray-bounds] 757 | memcpy(frame->data, msg_data.data, can_dlc_to_bytes(frame->dlc)); where the compiler detects that frame->data is 8 bytes long but can_dlc_to_bytes could return more than that. Can be reproduced with: west build -p -b s32z270dc2_rtu1_r52 \ -T samples/net/sockets/can/sample.net.sockets.can.one_socket Suggested-by: Martin Jäger <martin@libre.solar> Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
henrikbrixandersen
requested review from
fabiobaltieri,
martinjaeger,
karstenkoenig and
str4t0m
henrikbrixandersen
requested a review
from alexanderwachter
as a code owner
fabiobaltieri
approved these changes
Sep 18, 2023
martinjaeger
approved these changes
Sep 18, 2023
alexanderwachter
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4856fd4 from #62611.
Fixes: #62701, #62709