[Backport v3.3-branch] ipm: mcux and imx fixes #63175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 27, 2023 17:35
It is possible to happen a buffer overflow in ipm_send callback due a wrong comparison between signed/unsigned types. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> (cherry picked from commit 6654d18)
Since the driver is passing the whole buffer, let's zero it to avoid pass garbage in case of size != buffer's size. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> (cherry picked from commit 4ff32d9)
It is possible to happen a buffer overflow in ipm_send due the lack of a checking for negative value. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> (cherry picked from commit 0a12a05)
Since the driver is passing the whole buffer, let's zero it to avoid pass garbage in case of size != buffer's size. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> (cherry picked from commit 98857c2)
A buffer overflow happens in send() when size is negative because it is promoted to signed when used in memcpy. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> (cherry picked from commit eeea26d)
zephyrbot
requested review from
dcpleung,
andyross,
mmahadevan108 and
dleach02
as code owners
zephyrbot
added
Backport
zephyrbot
requested review from
danieldegrasse,
decsny,
DerekSnell,
EmilioCBen,
manuargue and
yvanderv
|
@ceolin can you file an issue for the backport please? |
Thanks! Yes, you can. If the original PR had an associated bug issue, we could have referenced that instead (even if it was closed already by merging the original PR). |
ceolin
approved these changes
Oct 26, 2023
stephanosio
approved these changes
Oct 31, 2023
|
@dleach02 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport eeea26d~5..eeea26d from #63069.
Fixes #64335