scripts: build: gen_isr_tables: Cleanup access to ".intList" #63282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakons
force-pushed
the
gen_isr_tables_cleanup
branch
from
f27d624
to
2327fc5
Compare
|
@evgeniy-paltsev could you please check that this works as expected with ARC mwdt. |
tejlmand
requested changes
Oct 2, 2023
| $<TARGET_PROPERTY:bintools,elfconvert_flag_infile>$<TARGET_FILE:${ZEPHYR_LINK_STAGE_EXECUTABLE}> | ||
| $<TARGET_PROPERTY:bintools,elfconvert_flag_outfile>isrList.bin | ||
| $<TARGET_PROPERTY:bintools,elfconvert_flag_final> | ||
| OUTPUT isr_tables.c |
There was a problem hiding this comment.
proposed change fails with armclang:
$ ninja -C build
ninja: Entering directory `build'
[1/134] Preparing syscall dependency handling
[2/134] Generating include/generated/version.h
-- Zephyr version: 3.4.99 (/projects/github/ncs/zephyr), build: zephyr-v3.4.0-4679-g2327fc53e19d
[131/134] Generating isr_tables.c
FAILED: zephyr/isr_tables.c /projects/github/ncs/zephyr/build/zephyr/isr_tables.c
cd /projects/github/ncs/zephyr/build/zephyr && /usr/bin/python3 /projects/github/ncs/zephyr/scripts/build/gen_isr_tables.py --output-source isr_tables.c --kernel /projects/github/ncs/zephyr/build/zephyr/zephyr_pre0.elf --sw-isr-table --vector-table
gen_isr_tables.py: error: Empty ".intList" section!
ninja: build stopped: subcommand failed.
There was a problem hiding this comment.
The generated linker_zephyr_pre0.cmd file for armclang contains:
IDT_LIST 0x20040000 NOCOMPRESS 0x800
{
intList 0x20040000
{
*.o(.irq_info, +First)
*.o(.intList)
}
}
The section name is without a dot, it should be ".intList".
Fix proposals:
- Update linker script to contain a do in intList section name
- Update the python script to accept ".intList" or "intList" section names.
There was a problem hiding this comment.
We have to go with the second answer. The section names preceded with dots should not be used as user sections. They are not strictly forbidden but they should be avoided and they are making trouble for clang. So updating clang scripts it not an option.
|
@tejlmand it works fine with ARC MWDT, thanks! |
rakons
force-pushed
the
gen_isr_tables_cleanup
branch
from
2327fc5
to
7027e68
Compare
tejlmand
previously approved these changes
Oct 4, 2023
This commit removes the needs or generating isrList.bin temporary file. Now gen_isr_tables.py script access the required section directly in elf file, that was accessed by the script anyway. It simplifies the building removing one step. Signed-off-by: Radosław Koppel <radoslaw.koppel@nordicsemi.no>
rakons
force-pushed
the
gen_isr_tables_cleanup
branch
from
7027e68
to
542efbb
Compare
tejlmand
approved these changes
Oct 4, 2023
|
@evgeniy-paltsev - We managed to make armclang working - are we good now to get acceptation and continue? |
carlocaione
approved these changes
Oct 5, 2023
|
@carlocaione let me test it again, just in case |
evgeniy-paltsev
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the needs or generating isrList.bin temporary file. Now gen_isr_tables.py script access the required section directly in elf file, that was accessed by the script anyway.
It simplifies the building removing one step.
This is the part of #60838 PR that should not rise any controversy.
Just simplification of the build process without changing the way the intList section is handled later.