Bluetooth: BAP: Add PSN debug log support #63607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa and
MariuszSkamra
larsgk
previously approved these changes
Oct 6, 2023
cvinayak
requested changes
Oct 6, 2023
subsys/bluetooth/audio/Kconfig.bap
Outdated
Comment on lines
285
to
287
| Use this option to enable Bluetooth Audio Stream sequence number debuggin logs for | ||
| the Bluetooth Audio functionality. This will provide an warning if the application | ||
| provide unexpected sequence numbers. |
There was a problem hiding this comment.
Suggested change
| Use this option to enable Bluetooth Audio Stream sequence number debuggin logs for | |
| the Bluetooth Audio functionality. This will provide an warning if the application | |
| provide unexpected sequence numbers. | |
| Use this option to enable Bluetooth Audio Stream sequence number debugging logs for | |
| the Bluetooth Audio functionality. This will provide a warning if the application | |
| provides unexpected sequence numbers. |
subsys/bluetooth/audio/bap_stream.c
Outdated
| @@ -273,6 +273,15 @@ int bt_bap_stream_send(struct bt_bap_stream *stream, struct net_buf *buf, | |||
| return -EBADMSG; | |||
| } | |||
|
|
|||
| #if defined(CONFIG_BT_BAP_DEBUG_STREAM_SEQ_NUM) | |||
| if (stream->_prev_seq_num != 0U && seq_num != 0U && stream->_prev_seq_num + 1 != seq_num) { | |||
There was a problem hiding this comment.
Suggested change
| if (stream->_prev_seq_num != 0U && seq_num != 0U && stream->_prev_seq_num + 1 != seq_num) { | |
| if (stream->_prev_seq_num != 0U && seq_num != 0U && (stream->_prev_seq_num + 1U) != seq_num) { |
Thalley
force-pushed
the
bap_stream_psn_debug
branch
from
d96fa28
to
288f3e4
Compare
larsgk
previously approved these changes
Oct 6, 2023
cvinayak
reviewed
Oct 6, 2023
subsys/bluetooth/audio/Kconfig.bap
Outdated
| default y | ||
| help | ||
| Use this option to enable Bluetooth Audio Stream sequence number debugging logs for | ||
| the Bluetooth Audio functionality. This will provide an warning if the application |
There was a problem hiding this comment.
Suggested change
| the Bluetooth Audio functionality. This will provide an warning if the application | |
| the Bluetooth Audio functionality. This will provide a warning if the application |
Add a Kconfig that enables support for logging and debugging invalid sequence numbers. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bap_stream_psn_debug
branch
from
288f3e4
to
a3e42ce
Compare
cvinayak
approved these changes
Oct 8, 2023
larsgk
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Kconfig that enables support for logging and debugging invalid sequence numbers.