tests: gdbstub: simple test #63672
Merged
tests: gdbstub: simple test #63672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
5151a8c
to
623243a
Compare
golowanow
force-pushed
the
gdbstub_test_simple
branch
2 times, most recently
from
26d2b0b
to
b741b2a
Compare
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
b741b2a
to
d476511
Compare
nashif
requested changes
Oct 12, 2023
gchwier
requested changes
Oct 12, 2023
scripts/pylib/pytest-twister-harness/src/twister_harness/fixtures.py
Outdated
Show resolved
Hide resolved
scripts/pylib/pytest-twister-harness/src/twister_harness/helpers/gdb.py
Outdated
Show resolved
Hide resolved
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
d476511
to
217aee8
Compare
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
217aee8
to
4924932
Compare
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
4924932
to
aa8f4e5
Compare
gchwier
previously approved these changes
Oct 13, 2023
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
90eb165
to
a2f3bbd
Compare
Clone samples/subsys/debug/gdbstub to tests and convert it back to a build-only sample aligned with documentation. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Gdbstub test improvements: using pytest fixtures, parametrization, and expected pattern matching on outputs from GDB and the test application. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Add QEMU_EXTRA_FLAGS as QEMU board config option. This allows Twister tests to provide additional device setup commands to QEMU in prj.conf or testcase.yaml configuration files. Example use case: to setup TCP or UDP network interfaces with non-conflicting port numbers in different test suites to avoid conflicts when Twister run tests in parallel on the same host. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Add `gdb_target_remote` test parameter for GDB `target remote` command instead of its hardcoded value to allow different types of gdbstub serial interfaces as well as different TCP ports in gdbstub test suites possibly run in parallel on the same host. Move all GDB log configuration parameters from GDB script to the fixture code. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Add a testcase to run the same test application and GDB script which we use for Zephyr GDB stub testing, but now with the GDB stub enabled at QEMU itself using it as a reference RDP backend implementation. This allows to check the Zephyr's gdbstub implementation has similar behavior as the reference. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Remove gdbstub sample (samples/subsys/debug/gdbstub) as duplicated by a test (tests/subsys/debug/gdbstub). Update the GDB stub documentation. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
golowanow
force-pushed
the
gdbstub_test_simple
branch
from
a2f3bbd
to
a7ba2bd
Compare
gopiotr
approved these changes
Oct 13, 2023
@nashif could you please look again after the changes done here. |
nashif
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gdbstub test with Twister pytest plugin:
as suggested at #63472 (review)
and follows #63061