Minor fixes to improve compatibility between the POSIX API and native builds #63866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The infinite loop during the stress needs to be broken with a small delay when built for native targets. Let's add it. Note that this delay is only added for ARCH_POSIX targets and not any other. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
This test should be compiled without host headers when built without the host libC, and at the same time, it does not support building with the host libC, so let's remove the condition that includes the host libC header to avoid extra confusion. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
The inclusion of the compiler provided sys/types.h should depend on not using the host C library, and not just of building for a native target. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
The infinite loop during the test needs to be broken with a small delay when built for native targets. Let's add it. Note that this delay is only added for ARCH_POSIX targets and not any other. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
cfriedt
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of minor fixes to improve compatibility between the POSIX API and native builds (most getting all POSIX API tests running on native_sim).
This is more obvious when combined with #63855