serial: nxp_s32: use instance-based DT macros #64230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: NXP
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
dbaluta,
dcpleung,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
mmahadevan108,
PetervdPerk-NXP and
yvanderv
zephyrbot
added
manifest
manifest-hal_nxp
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
decsny
previously approved these changes
Oct 31, 2023
bperseghetti
previously approved these changes
Nov 1, 2023
manuargue
force-pushed
the
manuargue-dt-inst-uart
branch
from
5a30e6f
to
09dcf9e
Compare
manuargue
force-pushed
the
manuargue-dt-inst-uart
branch
from
09dcf9e
to
0b67871
Compare
danieldegrasse
previously approved these changes
Nov 6, 2023
decsny
previously approved these changes
Nov 6, 2023
dleach02
previously approved these changes
Nov 6, 2023
At present, many of the NXP S32 shim drivers do not make use of devicetree instance-based macros because the NXP S32 HAL relies on an index-based approach, requiring knowledge of the peripheral instance index during both compilation and runtime, and this index might not align with the devicetree instance index. The proposed solution in this patch eliminates this limitation by determining the peripheral instance index during compilation through macrobatics and defining the driver's ISR within the shim driver itself. Note that for some peripheral instances is needed to redefine the HAL macros of the peripheral base address, since the naming is not uniform for all instances. Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
manuargue
dismissed stale reviews from dleach02, decsny, and danieldegrasse
via
8e9b20d
manuargue
force-pushed
the
manuargue-dt-inst-uart
branch
from
0b67871
to
8e9b20d
Compare
danieldegrasse
approved these changes
Nov 7, 2023
decsny
approved these changes
Nov 7, 2023
bperseghetti
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, many of the NXP S32 shim drivers do not make use of devicetree instance-based macros because the NXP S32 HAL relies on an index-based approach, requiring knowledge of the peripheral instance index during both compilation and runtime, and this index might not align with the devicetree instance index.
The proposed solution in this patch eliminates this limitation by determining the peripheral instance index during compilation through macrobatics and defining the driver's ISR within the shim driver itself.
Note that for some peripheral instances is needed to redefine the HAL macros of the peripheral base address, since the naming is not uniform for all instances.