ipc: Base icmsg implementation on added packed buffer #64624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eobalski
requested review from
nashif,
carlocaione,
carlescufi,
galak and
MaureenHelm
as code owners
zephyrbot
added
area: Samples
eobalski
added
area: IPC
eobalski
force-pushed
the
NCSDK-22744/ipc_pbuf
branch
from
859e999
to
775e386
Compare
zephyrbot
added
area: Samples
hubertmis
requested changes
Oct 31, 2023
eobalski
force-pushed
the
NCSDK-22744/ipc_pbuf
branch
7 times, most recently
from
1f126af
to
722ee81
Compare
hubertmis
reviewed
Nov 6, 2023
added 4 commits
November 7, 2023 13:40
Remove nocopy feature from icmsg_me backend. The backend is not meant to be used to send big data chunks thus no-copy feature is removed. If one wants to use no-copy it is recommended to use icmsg_me only for control messages while allocator will shall be written seperately. Signed-off-by: Emil Obalski <Emil.Obalski@nordicsemi.no>
This adds implementation of secure packed buffer. Secure packed buffer is added with intention to be used in icmsg backed backends. Signed-off-by: Emil Obalski <Emil.Obalski@nordicsemi.no>
Add unit tests for packed buffer. Signed-off-by: Emil Obalski <Emil.Obalski@nordicsemi.no>
Replace spsc_pbuf with pbuf implementation dedicated to be used by IcMsg based backends. The pbuf is written on top of simple read/write semantics with minimal footprint and code complexity Signed-off-by: Emil Obalski <Emil.Obalski@nordicsemi.no>
eobalski
force-pushed
the
NCSDK-22744/ipc_pbuf
branch
from
722ee81
to
0bdd0c9
Compare
hubertmis
approved these changes
Nov 7, 2023
carlocaione
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the implementation of the
icmsgbased backends by replacing use ofspsc_pbufwith newly addedpbuf.Note that at the begging when the
icmsgbackend was introduced it was written around similar memory access layer aspbuf(#43544).This change is a step back to what was the initial idea behind
icmsg- to be as simplest as possible.By this change no-copy API is no longer possible, but this trade off is intentional.
icmsgusingpbufis meant to be used for use cases where relatively small amount of data is send.Because of that complexity of no-copy is not a huge benefit.
In comparison to initial commit adding
icmsgbackend, thepbufimplementation is written with security awareness. For example reader does not rely onrd_idxreceived from the writer, and vice versa.