-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Misc fixes to "Report an issue" in the documentation functionality. #64788
Merged
carlescufi
merged 7 commits into
zephyrproject-rtos:main
from
kartben:fixes_report_issue
Nov 9, 2023
Merged
doc: Misc fixes to "Report an issue" in the documentation functionality. #64788
carlescufi
merged 7 commits into
zephyrproject-rtos:main
from
kartben:fixes_report_issue
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation to the get_page_prefix method. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
force-pushed
the
fixes_report_issue
branch
from
November 3, 2023 15:33
78675a1
to
a4811a1
Compare
kartben
changed the title
doc: Misc fixes to "Report an issue for this page" functionality.
doc: Misc fixes to "Report an issue" in the documentation functionality.
Nov 3, 2023
Thalley
reviewed
Nov 6, 2023
Compute ZEPHYR_BASE like other extensions do rather than artificially pretend it's a config option. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Use BuildEnvironment to get the path of a document. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Page prefix can be an empty string. Fixed the condition so that it only evaluates to try when prefix is truly None. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Not sure why I used square brackets for "[doc]" prefix of the default Github issue title. Change it to "doc:". Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Use get_maintainer.py to add more meaningful labels to issues creates from a documentation page. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Clarify the "Report an issue" label in HTML documentation. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
force-pushed
the
fixes_report_issue
branch
from
November 6, 2023 10:31
8efee69
to
f963ccd
Compare
Thalley
approved these changes
Nov 6, 2023
nashif
approved these changes
Nov 8, 2023
henrikbrixandersen
approved these changes
Nov 9, 2023
carlescufi
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 https://builds.zephyrproject.io/zephyr/pr/64788/docs/
Usability:
Bug fixes:
See commits for more details.