Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: add a multiplatform hello world workflow #64802

Merged
merged 1 commit into from
Jan 29, 2024
Merged

github: add a multiplatform hello world workflow #64802

merged 1 commit into from
Jan 29, 2024

Conversation

fabiobaltieri
Copy link
Member

@fabiobaltieri fabiobaltieri commented Nov 3, 2023 •
edited
Loading

Add a new workflow to build the hello world sample application on all three supported platforms using the reusable setup action.

@fabiobaltieri fabiobaltieri force-pushed the ci-hello-world-multi branch 24 times, most recently from 012c39e to cb8e5c9 Compare November 4, 2023 14:39
@fabiobaltieri fabiobaltieri mentioned this pull request Nov 7, 2023
Closed
@fabiobaltieri fabiobaltieri force-pushed the ci-hello-world-multi branch 5 times, most recently from e044b08 to 8322cf8 Compare November 9, 2023 10:45
@zephyrbot zephyrbot requested a review from galak January 12, 2024 15:43
@fabiobaltieri
Copy link
Member Author

This is now using zephyrproject-rtos/action-zephyr-setup@main, currently set up to run on push and changes in scripts/build/. May make sense to include cmake/ as well? Undecided, guess we can always expand later.

gmarull
gmarull reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it enough to test this on example-app?

@kartben
Copy link
Collaborator

kartben commented Jan 12, 2024

isn't it enough to test this on example-app?

I think it's fair to test in CI that we actually have a somewhat functional Hello World on all our supported dev environment, as right now we don't really have anything that really tests the macOS "getting started like" experience, for example.

@fabiobaltieri
Copy link
Member Author

isn't it enough to test this on example-app?

I was thinking at hello-world as the practical example one can use to set up their project CI, and this one would hopefully catch regression before they hit the example application (it runs in the PR if the right files are touched).

@kartben
Copy link
Collaborator

kartben commented Jan 12, 2024

it runs in the PR if the right files are touched).

Oh right, I missed that -- didn't we say we'd probably want to run it on every PR? Or if not, then the paths might be incomplete, no? What if requirements.txt gets updated and Python env setup has a regression on macOS? (which I think is actually the kind of situation that originally triggered this work)?

@fabiobaltieri
Copy link
Member Author

didn't we say we'd probably want to run it on every PR?

I think we meant: every PR merged (the push event). GitHub public runners are free for public projects but only up to a certain capacity, I think like 20 concurrent instances or something. I think that running for every PR would get us way over that, but fair point it certainly make sense to include requirements in the pull_request trigger, let me update that.

stephanosio
stephanosio requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still looks like nothing is being built on macOS and Windows runs.

.github/workflows/hello_world_multiplatform.yaml Outdated Show resolved Hide resolved
@fabiobaltieri fabiobaltieri mentioned this pull request Jan 20, 2024
Merged
@tejlmand tejlmand removed their request for review January 24, 2024 22:12
@fabiobaltieri
Copy link
Member Author

Tagged and updated to uses: zephyrproject-rtos/action-zephyr-setup@v1

@fabiobaltieri
github: add a multiplatform hello world workflow
8ebd1bf 
Add a new workflow to build the hello world sample application on all
three supported platforms using the reusable setup action.

Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
@dleach02 dleach02 merged commit f65f6e5 into zephyrproject-rtos:main Jan 29, 2024
15 checks passed
@fabiobaltieri fabiobaltieri deleted the ci-hello-world-multi branch January 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarull gmarull gmarull left review comments

@stephanosio stephanosio stephanosio approved these changes

@kartben kartben kartben approved these changes

@nashif nashif Awaiting requested review from nashif

@galak galak Awaiting requested review from galak

Assignees

@stephanosio stephanosio

Labels
area: Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fabiobaltieri @kartben @stephanosio @gmarull @zephyrbot @dleach02