drivers: regulator: npm1300: Add boot state detection #64843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
previously approved these changes
Nov 6, 2023
| int regulator_npm1300_init(const struct device *dev) | ||
| { | ||
| const struct regulator_npm1300_config *config = dev->config; | ||
| bool enabled = false; |
There was a problem hiding this comment.
no need to initialize this one
Added boot state detection, so that the reference count is set correctly and enable/disable work as expected. With this fix it is no longer necessary to set regulator-boot-on when the regulator is enabled in hardware. Signed-off-by: Andy Sinclair <andy.sinclair@nordicsemi.no>
aasinclair
force-pushed
the
npm1300-regulator-boot-state-detect
branch
from
dc1a45a
to
67347c2
Compare
fabiobaltieri
approved these changes
Nov 7, 2023
gmarull
approved these changes
Nov 7, 2023
gmarull
reviewed
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added boot state detection, so that the reference count is set correctly and enable/disable work as expected.
With this fix it is no longer necessary to set
regulator-boot-on when the regulator is enabled in hardware.