Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular fixes #64936

Closed
wants to merge 2 commits into from
Closed

Cellular fixes #64936

wants to merge 2 commits into from

Conversation

KimBP
Copy link
Contributor

@KimBP KimBP commented Nov 7, 2023

Looking a bit into the new cellular stuff I realized more of the samples can't build with the different boards.
So little is needed to make it work, so worth it I think

More of the defined DT_DRV_COMPAT's would clash with the corresponding
modem low-level driver resulting in multiple definition of a
__device_dts_ord_xx symbol

Signed-off-by: Kim Bøndergaard <kim@fam-boendergaard.dk>
The cellular driver expects an alias of name 'modem'


Signed-off-by: Kim Bøndergaard <kim@fam-boendergaard.dk>
Copy link
Collaborator

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to devicetree compatibles, in this case redefining the compatible used in the cellular driver, which results in the driver not building at all for any board (more specifically not creating any struct devices when built), is a no from me :)

@rerickson1
Copy link
Member

For pinnacle_100_dvk and mg100 to work with the cellular modem sample, board overlays are needed in the sample.

@KimBP
Copy link
Contributor Author

KimBP commented Nov 7, 2023

Yes - I guess you are right. My misunderstanding.
This was purely based on my build result. Unfortunately my only modem is on a (yet) unsupported board, so haven't had a change to verify it.

Wander how sample_cellular_modem has been tested. My guess is that it has been tested only on a quectel bg95 which is referred as a quectel,bg95 in modem_cellular and as quectel,bg9x in the quectel driver.
That's a problem we need to solve.

For now I'll retract this PR

@KimBP KimBP closed this Nov 7, 2023
@KimBP
Copy link
Contributor Author

KimBP commented Nov 8, 2023

For pinnacle_100_dvk and mg100 to work with the cellular modem sample, board overlays are needed in the sample.

That's one way to solve the lack of the modem alias. Still though you'll get a linker conflict with multiple definitions of __devices_dts_ord_xx (defined in both modem_cellular.c.obj and the hl8700 driver)

@rerickson1
Copy link
Member

For pinnacle_100_dvk and mg100 to work with the cellular modem sample, board overlays are needed in the sample.

That's one way to solve the lack of the modem alias. Still though you'll get a linker conflict with multiple definitions of __devices_dts_ord_xx (defined in both modem_cellular.c.obj and the hl8700 driver)

You need a kconfig overlay to disable the HL7800 driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants