-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular fixes #64936
Cellular fixes #64936
Conversation
More of the defined DT_DRV_COMPAT's would clash with the corresponding modem low-level driver resulting in multiple definition of a __device_dts_ord_xx symbol Signed-off-by: Kim Bøndergaard <kim@fam-boendergaard.dk>
The cellular driver expects an alias of name 'modem' Signed-off-by: Kim Bøndergaard <kim@fam-boendergaard.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to devicetree compatibles, in this case redefining the compatible used in the cellular driver, which results in the driver not building at all for any board (more specifically not creating any struct devices when built), is a no from me :)
For |
Yes - I guess you are right. My misunderstanding. Wander how sample_cellular_modem has been tested. My guess is that it has been tested only on a quectel bg95 which is referred as a quectel,bg95 in modem_cellular and as quectel,bg9x in the quectel driver. For now I'll retract this PR |
That's one way to solve the lack of the modem alias. Still though you'll get a linker conflict with multiple definitions of __devices_dts_ord_xx (defined in both modem_cellular.c.obj and the hl8700 driver) |
You need a kconfig overlay to disable the HL7800 driver. |
Looking a bit into the new cellular stuff I realized more of the samples can't build with the different boards.
So little is needed to make it work, so worth it I think