[RFC] scripts: gen_defines: expose controllers in interrupts-extended prop
#66687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the generated devicetree only has the interrupt number in the `interrupts-extended` properties, the controller for the interrupt isn't exposed and can't be access in the source. This patch exposes those controllers as `parent` cell in `devicetree_generated.h`, i.e.: ```c #define DT_<node>_IRQ_IDX_0_VAL_parent DT_<node> #define DT_<node>_IRQ_IDX_0_VAL_parent_EXISTS 1 ``` so that they can be accessed by `DT_IRQ_*` macros, i.e.: - DT_IRQ_BY_IDX(node_id, idx, cell) - DT_IRQ_BY_NAME(node_id, name, cell) Updated devicetree api tests to complement this addition. Signed-off-by: Yong Cong Sin <ycsin@meta.com>
|
superseded by #66707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch basically outputs the parent controller(s) in the
interrupts-extendedif it is available asIRQ_*_VAL_parent, along withIRQ_*_VAL_irq&IRQ_*_VAL_priority, the upside to this is that it can be accessed with existing DT macros, the downside is that it looks somewhat like a hack.fixes #66682