Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: releases: Build system: Introduction of LTO #68542

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

rakons
Copy link
Collaborator

@rakons rakons commented Feb 5, 2024

This commit adds documentation about added functionality for now interrupt tables parser and Link Time Optimisation.

@microbuilder
Copy link
Member

Related PR for context: #66392

Comment on lines 152 to 162
* Added functionality for Link Time Optimisation.
This change includes interrupt script generator rebuilding and adding following options:

- :kconfig:option:`CONFIG_ISR_TABLES_LOCAL_DECLARATION` Kconfig option:
LTO compatible interrupt tables parser,
- :kconfig:option:`CONFIG_LTO` Kconfig option: Enable Link Time Optimisation.

Currently the LTO compatible interrupt tables parser is only supported by ARM architectures and
GCC compiler/linker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding a mention of the PR number here for anyone interested in the details (#66392)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

microbuilder
microbuilder previously approved these changes Feb 5, 2024
carlescufi
carlescufi previously approved these changes Feb 5, 2024

Currently the LTO compatible interrupt tables parser is only supported by ARM architectures and
GCC compiler/linker.
See `pull request 66392 <https://github.com/zephyrproject-rtos/zephyr/pull/66392>`_ for details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoding links in the documentation should be avoided.

Suggested change
See `pull request 66392 <https://github.com/zephyrproject-rtos/zephyr/pull/66392>`_ for details.
See pull request :github:`66392` for details.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 152 to 157
* Added functionality for Link Time Optimisation.
This change includes interrupt script generator rebuilding and adding following options:

- :kconfig:option:`CONFIG_ISR_TABLES_LOCAL_DECLARATION` Kconfig option:
LTO compatible interrupt tables parser,
- :kconfig:option:`CONFIG_LTO` Kconfig option: Enable Link Time Optimisation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: American English form (but we don't have a strict rule here --maybe we should-- so feel free to ignore :))

Suggested change
* Added functionality for Link Time Optimisation.
This change includes interrupt script generator rebuilding and adding following options:
- :kconfig:option:`CONFIG_ISR_TABLES_LOCAL_DECLARATION` Kconfig option:
LTO compatible interrupt tables parser,
- :kconfig:option:`CONFIG_LTO` Kconfig option: Enable Link Time Optimisation.
* Added functionality for Link Time Optimization.
This change includes interrupt script generator rebuilding and adding following options:
- :kconfig:option:`CONFIG_ISR_TABLES_LOCAL_DECLARATION` Kconfig option:
LTO compatible interrupt tables parser,
- :kconfig:option:`CONFIG_LTO` Kconfig option: Enable Link Time Optimization.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

This commit adds documentation about added functionality
for now interrupt tables parser and Link Time Optimisation.

Signed-off-by: Radosław Koppel <radoslaw.koppel@nordicsemi.no>
@MaureenHelm MaureenHelm merged commit 6aac89b into zephyrproject-rtos:main Feb 5, 2024
14 checks passed
@rakons rakons deleted the lto_release_notes branch February 6, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants