driver: ssp: update Intel SSP DAI driver to support dynamic SSP link management #70660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnikodem
force-pushed
the
update_ssp_driver_flow
branch
2 times, most recently
from
9a28be8
to
4d1f412
Compare
1 task
dnikodem
force-pushed
the
update_ssp_driver_flow
branch
3 times, most recently
from
a9113b3
to
e90b5c7
Compare
dnikodem
requested review from
dcpleung,
kv2019i,
marcinszkudlinski and
abonislawski
as code owners
zephyrbot
added
area: I2S
area: Xtensa
zephyrbot
requested review from
andyross,
ceolin,
iuliana-prodan,
juimonen,
jxstelter,
lgirdwood,
lyakh,
marc-hb,
nashif,
softwarecki and
tmleman
kv2019i
approved these changes
Apr 9, 2024
| LOG_INF("plat_data base: %u", dp->plat_data.base); | ||
| LOG_INF("plat_data irq: %u", dp->plat_data.irq); | ||
| LOG_INF("plat_data fifo playback offset: %u", dp->plat_data.fifo[DAI_DIR_PLAYBACK].offset); | ||
| LOG_INF("dai index: %u", dp->dai_index); |
There was a problem hiding this comment.
Should we display the link number in the logs somehow as it's a new piece of config data?
kv2019i
reviewed
Apr 9, 2024
drivers/dai/intel/ssp/ssp.c
Outdated
| struct intel_ssp_link *ssp_link = dai_get_ssp_link(dp); | ||
|
|
||
| if (ssp_link_is_acquired(ssp_link)) { | ||
| k_free(dai_get_drvdata(dp)); |
There was a problem hiding this comment.
One more, can you explain the logic here? If the link is acquired, how come we proceed to free the "'dp' object in this case?
kv2019i
requested changes
Apr 10, 2024
dnikodem
force-pushed
the
update_ssp_driver_flow
branch
3 times, most recently
from
ff344f6
to
163eba8
Compare
kv2019i
previously approved these changes
Apr 18, 2024
dnikodem
force-pushed
the
update_ssp_driver_flow
branch
from
163eba8
to
fb0a689
Compare
kv2019i
previously approved these changes
Apr 22, 2024
|
@nashif This would be ready to go. |
tmleman
reviewed
Apr 24, 2024
…ement This commit refactors the Intel SSP DAI driver to support dynamic management of SSP IP. This change additionally separates the management of the DAI part from the management part of the SSP IP. Key changes: - Add new static functions to manage SSP IP power. - Update the DAI SSP configuration functions to use the new management approach. - Update device tree bindings and instances to reflect the new SSP IP management mechanism. Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
dnikodem
force-pushed
the
update_ssp_driver_flow
branch
from
fb0a689
to
d393c9c
Compare
tmleman
approved these changes
Apr 24, 2024
kv2019i
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the Intel SSP DAI driver to support dynamic management of SSP links. The changes include the introduction of a new structure
intel_ssp_linkto encapsulate SSP link-specific data.Key changes:
The new approach allows for more flexible and maintainable management of SSP links.
Related, necessary changes: