-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
everywhere: replace double words #74650
Conversation
f6db496
to
bd4fe5e
Compare
Learn by analogy: there are also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to to
, if if
, that that
, on on
, is is
So I recommend filtering all words.
I'm with @LingaoM , let's do even more if you don't mind, @JordanYates :) You may also want to search more smartly, something like
|
@LingaoM Please note that a PR should not be blocked to demand "more" fixes (https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#reviewer-expectations9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool cool ❤️
f1812c6
to
11a05df
Compare
hopefully this did not remove any valid |
Would it make sense to add this sort of check to CI? |
Treewide search and replace on a range of double word combinations: * `the the` * `to to` * `if if` * `that that` * `on on` * `is is` * `from from` Signed-off-by: Jordan Yates <jordan@embeint.com>
Add double prepositions to the default spelling check list. Signed-off-by: Jordan Yates <jordan@embeint.com>
85c8ba9
11a05df
to
85c8ba9
Compare
This PR includes an update to |
Treewide search and replace on a range of double word combinations:
*
the the
*
to to
*
if if
*
that that
*
on on
*
is is
*
from from
Add double prepositions to the default spelling check list.