Add nrf54h20dk cpuppr configuration to SPI tests #74860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
jaz1-nordic,
magp-nordic,
tbursztyka and
teburd
nordic-krch
force-pushed
the
spi_ppr
branch
2 times, most recently
from
fd03d9e
to
9ae7d55
Compare
nordic-krch
force-pushed
the
spi_ppr
branch
2 times, most recently
from
edaa7dd
to
f9194a6
Compare
nordic-krch
force-pushed
the
spi_ppr
branch
3 times, most recently
from
0d529f2
to
0b8e5c3
Compare
zephyrbot
added
area: I2C
area: UART
nordic-krch
force-pushed
the
spi_ppr
branch
2 times, most recently
from
06401ab
to
8f15398
Compare
kl-cruz
previously approved these changes
Sep 3, 2024
nordic-krch
force-pushed
the
spi_ppr
branch
from
8f15398
to
63b187c
Compare
nordic-krch
force-pushed
the
spi_ppr
branch
from
63b187c
to
f2ccabd
Compare
|
@masz-nordic @anangl can you take a look? |
masz-nordic
previously approved these changes
Sep 23, 2024
gmarull
reviewed
Sep 23, 2024
Comment on lines
18
to
24
| if BOARD_NRF54H20DK_NRF54H20_CPUPPR | ||
|
|
||
| # As PPR has limited memory most of tests does not fit with asserts enabled. | ||
| config ASSERT | ||
| default n | ||
|
|
||
| endif # BOARD_NRF54H20DK_NRF54H20_CPUPPR |
There was a problem hiding this comment.
why not enable this at soc level?, also, make it conditional to ztest maybe? like
config ASSERT
default n if ZTEST
There was a problem hiding this comment.
right, done for soc level.
As for assert kconfig. I used to have like you suggested but changed based on that comment: #74297 (comment)
nordic-krch
force-pushed
the
spi_ppr
branch
from
f2ccabd
to
4428355
Compare
gmarull
previously approved these changes
Sep 24, 2024
masz-nordic
previously approved these changes
Sep 24, 2024
nordic-krch
dismissed stale reviews from masz-nordic and gmarull
via
8d02717
nordic-krch
force-pushed
the
spi_ppr
branch
from
4428355
to
8d02717
Compare
In order to allow fiting test in targets with smaller memory make large buffer configurable through Kconfig. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Add overlay for nrf54h20dk cpurad. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Add configuration for nrf54h20dk//cpuppr target. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Rework existing nrf54h20dk overlays to allow adding of nrf54h20dk//cpuppr target. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Rework overlays and add sysbuild/vpr_launcher folder to allow standard test configuration for nrf54h20dk cpuppr. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
hakehuang
approved these changes
Oct 22, 2024
|
@gmarull @masz-nordic @kl-cruz can you re-approve? I had to rebase. |
gmarull
approved these changes
Oct 23, 2024
|
@tbursztyka can you take a look? |
tbursztyka
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for
spi_loopbackandspi_controller_peripheraltests. Reworked configuration ofspi_error_casesusing same scheme of configuration as for other tests which does not require special case intestcase.yaml.