scripts: print the file name when decode syscall #75128
Conversation
zephyrbot
added
area: Build System
size: XS
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
|
Hello @Sasasu, and thank you very much for your first pull request to the Zephyr project! |
|
I am trying to init a new zyphyr project, looks the non-utf8 code file is not a network error. Can I send PR to those HAL repos? Or try to add more code in this python file to support reading non-utf8 files? zephyrproject-rtos/hal_altera#2 If this method is acceptable, I can send PR to HAL repo |
that's a long list of files. Have you made any extra changes in your workspace which triggers this problem ?
Of course, but some repos are maintained outside of Zephyr and then synced regularly, in which case a PR against the origin repo is better.
Before doing so I would like to understand why those files are suddenly being parsed by the Also see guide-lines here: https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style
and the discussion here: #70610 (comment) I notice zephyrproject-rtos/hal_altera#2 is actually changing a comment, not code, but I would say |
I run I think modifying the error message is enough, others can find the solution if they do the search in GitHub issues and can find this PR. The solution is run
Actually, all non-utf8 characters are comment. Like the |
Not fully clear to me how your west workspace directory structure looks like based on this description, but this doesn't sound like a T2 or T3 topology, as described here: https://docs.zephyrproject.org/latest/develop/west/workspaces.html#topologies-supported Note that the example-application uses a T2 topology. Can you try to sketch your west workspace directory structure using same principle as is used on the supported topology page ? |
|
@Sasasu could you please address the compliance issues in your commit message. See https://github.com/zephyrproject-rtos/zephyr/actions/runs/9700408884/job/26882772828?pr=75128 |
|
@Sasasu best to just remove the log from the commit message so that compliance can pass |
the script shows an incorrect file name, I check the wrong file first, then I find the script did not print the current reading file name. Fix this to prevent others from wasting their time on this. The new error message: ``` [1/179] Generating syscalls.json, struct_tags.json Error decoding zmk/.../altera_msgdma.c (included in zephyr/.../ethernet.c) ``` Signed-off-by: Sa Sasu <i@sasa.su>
|
Hi @Sasasu! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
the script shows an incorrect file name, I check the wrong file first, then I find the script did not print the current reading file name.
Fix this to prevent others from wasting their time on this.
The new error message: