code_relocation: Allow processing of object files #75738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
57300,
ceolin,
dcpleung,
jeremybettis,
nashif,
nordicjm and
tejlmand
dennisgr102
force-pushed
the
allow_object_file_relocation
branch
from
67dae19
to
9cbb476
Compare
Allow processing of object files Signed-off-by: Dennis Grijalva <dennisgrijalva@meta.com>
dennisgr102
force-pushed
the
allow_object_file_relocation
branch
from
9cbb476
to
a3c70c6
Compare
tejlmand
reviewed
Aug 2, 2024
There was a problem hiding this comment.
changes looks fine, but I would like you to extend the existing test cases to verify relocation of an object file.
You should be able to use this feature with one of the compiled object files instead of passing the source file, and thus avoid adding object files to git.
This will also help users / serve as documentation that object files can be relocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the relocation script to process object files by checking the suffix and only assuming it's a source file if it does not end in ".o" or ".obj".
The motivation behind this change is that I am trying to relocate code which is in a prebuilt static library archive. In order to do so, I am unarchiving the library and passing the object files for relocation.