Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: bluetooth: Fix line endings for imported ICS configuration #75809

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

sjanc
Copy link
Collaborator

@sjanc sjanc commented Jul 12, 2024

Unfortunatelly new Qualification Workspace is not able to properly import ICS if file is UNIX line endings.

theob-pro
theob-pro previously approved these changes Jul 12, 2024
@sjanc
Copy link
Collaborator Author

sjanc commented Jul 12, 2024

qualification tool is not yet updated so I manually fixed MESH MBT and DFU names

Thalley
Thalley previously approved these changes Jul 12, 2024
jhedberg
jhedberg previously approved these changes Jul 12, 2024
@Thalley
Copy link
Collaborator

Thalley commented Jul 15, 2024

@sjanc and others: This PR is only a partial fix, and the file is also converted into a UTF-8-BOM file.

I've created an alternative PR #75890 that fixes all the PTS file, and not just one, as well as adding an .editorconfig file

@sjanc
Copy link
Collaborator Author

sjanc commented Aug 8, 2024

@carlescufi ping, this is ready to merge

@sjanc
Copy link
Collaborator Author

sjanc commented Aug 19, 2024

gentle ping

Unfortunatelly new Qualification Workspace is not able to properly import
ICS if file is UNIX line endings.

Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
@zephyrbot zephyrbot added the area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests label Aug 20, 2024
@nashif nashif merged commit 4216bed into zephyrproject-rtos:main Aug 20, 2024
24 of 25 checks passed
@sjanc sjanc deleted the bt_ics branch August 21, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests area: Bluetooth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants