Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v3.7-branch] linker: section_tags: fix missing include #76602

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[Backport v3.7-branch] linker: section_tags: fix missing include #76602

merged 1 commit into from
Sep 6, 2024

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Aug 1, 2024 •
edited by ycsin
Loading

Backport 77eafac from #76100.

Fixes #76254

@Finomnis @github-actions
linker: section_tags: fix missing include
a45aa67 
If using `<zephyr/linker/section_tags.h>` without including
`zephyr/linker/sections.h` as well, we get a warning an the linker fails
to place the data in the desired section.

Signed-off-by: Martin Stumpf <finomnis@gmail.com>
(cherry picked from commit 77eafac)
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues area: Linker Scripts labels Aug 1, 2024
@zephyrbot zephyrbot requested a review from nashif August 1, 2024 14:45
@Finomnis
Copy link
Contributor

Finomnis commented Sep 4, 2024

@nashif, @ycsin Is there something I can assist with here? Or will the backport just happen without me having to do anything?

@ycsin ycsin closed this Sep 6, 2024
@ycsin ycsin reopened this Sep 6, 2024
@ycsin ycsin added the bug The issue is a bug, or the PR is fixing a bug label Sep 6, 2024
@ycsin
Copy link
Member

ycsin commented Sep 6, 2024

@nashif, @ycsin Is there something I can assist with here? Or will the backport just happen without me having to do anything?

It will be merged when it gets enough approvals, you can probably try posting this in the discord pr-help channel for more visibility

@nashif nashif merged commit 5c8d7b2 into v3.7-branch Sep 6, 2024
51 of 52 checks passed
@nashif nashif deleted the backport-76100-to-v3.7-branch branch September 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycsin ycsin ycsin approved these changes

@nashif nashif nashif approved these changes

Assignees

@nashif nashif

Labels
area: Linker Scripts Backport Backport PR and backport failure issues bug The issue is a bug, or the PR is fixing a bug
Projects
Backports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zephyrbot @Finomnis @ycsin @nashif