Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v3.7-branch] kernel: fatal: Fix NO_OPTIMIZATIONS build (logging + no multithreading) #76810

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

zephyrbot
Copy link
Collaborator

Backport 28b4bab from #75585.

When logging is on and optimization and multithreading is off then
build fails to link because unoptimized compiler/linker seems to not
look beyond the function and it fails trying to link k_thread_name_get.
Reworking the code to make it known to the compiler without optimization
that k_thread_name_get is not needed and not logging current thread
name in that case.

Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
(cherry picked from commit 28b4bab)
Copy link
Collaborator

@peter-mitsis peter-mitsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why a zephyrbot initiated backport did not add in the "FIxes ..." line, but aside from that, this looks good to me.

@henrikbrixandersen henrikbrixandersen added this to the v3.7.1 milestone Nov 4, 2024
@henrikbrixandersen
Copy link
Member

This needs a bug report in order to get backported.

@nashif nashif merged commit f7e9a60 into v3.7-branch Nov 11, 2024
31 of 32 checks passed
@nashif nashif deleted the backport-75585-to-v3.7-branch branch November 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Kernel Backport Backport PR and backport failure issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants