Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spi: rtio: Refactor common SPI RTIO APIs to use across common drivers #77136

Merged
merged 4 commits into from
Sep 16, 2024
Merged

spi: rtio: Refactor common SPI RTIO APIs to use across common drivers #77136

merged 4 commits into from
Sep 16, 2024

Commits on Sep 16, 2024

  1. spi: mcux_lpspi: Refactor driver to extract common RTIO functionality 

    As a step to make them common code: spi_rtio.c.
Verified this refactorization builds and passes spi_loopback, both with
CONFIG_SPI_RTIO enabled, as well as disabled. Tested on mimxrt1010_evk.

Signed-off-by: Luis Ubieda <luisf@croxel.com>
    @ubieda
    ubieda committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    da7922d View commit details
    Browse the repository at this point in the history

  2. spi: spi_mcux_lpspi: Removed spin lock from iodev_start 

    Does not seem to be required. This allows hiding away the spin lock APIs.

Signed-off-by: Luis Ubieda <luisf@croxel.com>
    @ubieda
    ubieda committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f628a15 View commit details
    Browse the repository at this point in the history

  3. spi: rtio: Extract common APIs into separate file 

    Extracted common SPI RTIO operations from the spi_mcux_lpspi driver
into spi_rtio, which should be common across RTIO drivers.

Tested with spi_loopback with and without CONFIG_SPI_RTIO. Ran on
mimxrt1010_evk.

Also, verified the other SPI RTIO driver (spi_sam) is not broken by
these changes (tested building for target: robokit1 with the same
conditions as above).

Signed-off-by: Luis Ubieda <luisf@croxel.com>
    @ubieda
    ubieda committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    37b6ad1 View commit details
    Browse the repository at this point in the history

  4. spi: rtio: Move spi_rtio_copy to spi_rtio 

    To group all common APIs for SPI RTIO.

Signed-off-by: Luis Ubieda <luisf@croxel.com>
    @ubieda
    ubieda committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    48146dc View commit details
    Browse the repository at this point in the history