spi: sam: Refactor driver to use SPI RTIO common APIs #77190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubieda
added
area: SPI
ubieda
force-pushed
the
ubieda/spi-rtio-refactor-sam
branch
3 times, most recently
from
950f150
to
613547b
Compare
- Following similar approach followed on spi_mcux_lpspi driver. - Enabling DMA by default when SPI RTIO is selected to favor non-blocking transfers. Signed-off-by: Luis Ubieda <luisf@croxel.com>
ubieda
force-pushed
the
ubieda/spi-rtio-refactor-sam
branch
from
613547b
to
202c883
Compare
|
@teburd would you mind running a smoke-test on the robokit? I've built it and it looks okay but it's much better if it passes the tests. |
zephyrbot
requested review from
attie-argentum,
mnkp,
nandojve,
pdgendt,
stephanosio,
tbursztyka and
teburd
|
I can test against the icm42688, don’t recall if the Sam has an internal loop back feature. The robokit doesn’t easily expose the spi bus for looping. |
|
Hopefully we'll have time to get this in before feature freeze. |
MaureenHelm
approved these changes
Oct 21, 2024
teburd
approved these changes
Oct 22, 2024
|
@tbursztyka may I get this reviewed? Thanks! |
tbursztyka
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the SPI SAM driver to use SPI RTIO common APIs in a similar approach followed on spi_mcux_lpspi.
Testing
Build SPI Loopback sample with and without CONFIG_SPI_RTIO:
Note
Running tests on-target is pending, as of lack of hardware.