net: openthread: Fix the handling of address state changes #77210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
canisLupus1313,
edmont,
jukkar,
maciejbaczmanski,
mariuszpos,
pdgendt,
rlubos,
ssharks and
tbursztyka
This commit ensures that the state of the address can be changed from the Deprecated state to the Preferred state. Additionally, an issue with improper memory comparison size for the mesh local prefix has been fixed. Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
LuDuda
force-pushed
the
pr/ip-deprecation
branch
from
b6bc933
to
4d5c9f3
Compare
edmont
approved these changes
Aug 19, 2024
jukkar
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #76671 fixed the issue where a deprecated address might have been used as a source address, leading to routing issues until the address was completely removed. What was missed in the implementation was the case where the address changes its state back to "preferred" from "deprecated." In such case OpenThread emits
OT_CHANGED_IP6_ADDRESS_REMOVEDandOT_CHANGED_IP6_ADDRESS_ADDEDevents, but it does so simultaneously in one callback and without the hard removal that was previously assumed. This commit simply removes the if-statement, allowing the address state to be set at any time, whether during the initial addition of the address or during any update. Btw. I believe the current implementation of synchronization of the addresses coulb be simplified by utilizing a new APIotIp6SetAddressCallback- i can look at this in the future.Testing was conducted manually by removing/adding the prefix and observing the
net ipv6shell output.Additionally, during static code analysis, I believe I found an issue with prefix comparison in the
is_mesh_prefixfunction. It was assumed that the prefix was the size of a pointer, which in rare situations, where the mesh-local prefix and on-mesh prefix have the same first bytes, may lead to a situation where no communication can occur.