Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCXW71 base enablement #77434

Merged

Conversation

decsny
Copy link
Member

@decsny decsny commented Aug 22, 2024

MCXW71 SOC base enablement

@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@17aac63 zephyrproject-rtos/hal_nxp@f4e26fa (master) zephyrproject-rtos/hal_nxp@17aac63d..f4e26fad

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Aug 22, 2024
# SPDX-License-Identifier: Apache-2.0
#

zephyr_library()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file can go

Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change request is specifically over the lack of doc pages, if I have somehow missed them please feel free to dismiss it

drivers/clock_control/clock_control_mcux_scg_k4.c Outdated Show resolved Hide resolved
drivers/pinctrl/pinctrl_kinetis.c Outdated Show resolved Hide resolved
};
};

fast_peripheral: peripheral@58000000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused here- why define fast_peripheral and peripheral? Are there peripherals that can be declared under fast_peripheral and peripheral? If not, why not just define all the peripherals under peripheral- it seems like we only need the ranges property for secure vs nonsecure mode.

Copy link
Member Author

@decsny decsny Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now there isn't a practical reason, the purpose had nothing to do with the ranges property, it's just because according to the RM these are different peripheral buses with different sets of masters who can access them so I just felt it might be useful for something down the line to capture this aspect of the hardware in DT

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we group these, unless there's a strong reason not to. That will make the nonsecure definition of this part a little simpler, and is consistent with our other M33 SOCs.

Copy link
Member Author

@decsny decsny Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I was thinking the cortex-m3 DTS would then be able to delete the &fast_peripheral bus node to have an accurate DT since it can't access that bridge but it looks like in the public RM it says even though the radio subsystem is documented pretty well and is very flexible, that the firmware programmed to the radio NBU is intended to be developed by NXP ? so maybe we don't want to support the M3 target for this chip on zephyr anyways, so we can pretend that there is not two peripheral bridges for the DT if it's that important

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that is quite a good reason. I'm fine to keep it as is then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll just change it for now because I don't think we will have the m3 target any time soon, if ever

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, On W71, the m3 target is not supposed to be open, so we shouldn't consider it as a target for zephyr.
It will be different on W72, where the NBU will run on a CM33+nodsp+nofpu and will be open.

dts/arm/nxp/nxp_mcxw71.dtsi Outdated Show resolved Hide resolved
boards/nxp/frdm_mcxw71/frdm_mcxw71.yaml Show resolved Hide resolved
boards/nxp/frdm_mcxw71/board.yml Outdated Show resolved Hide resolved
@decsny decsny marked this pull request as draft September 4, 2024 16:42
@decsny decsny force-pushed the feature/mcxw_base_enable branch 2 times, most recently from 627b09d to c87d238 Compare September 6, 2024 13:43
danieldegrasse
danieldegrasse previously approved these changes Sep 17, 2024
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Sep 19, 2024
danieldegrasse
danieldegrasse previously approved these changes Sep 19, 2024
EmilioCBen
EmilioCBen previously approved these changes Sep 19, 2024
dleach02
dleach02 previously approved these changes Sep 19, 2024
Add driver for newer SCG clock control peripheral.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add support for SCG K4 clock control in kinetis pinctrl.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add SOC DTS for MCXW71.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add MCXW71 SOC, which inherits some qualitiies
of kinetis heritage platforms.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add FRDM-MCXW71 initial board.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add support for flash_k4 api from the mcux SDK.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Enable flash controller driver for main FMU on MCXW71

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
@decsny decsny assigned dleach02 and unassigned nordic-krch Sep 20, 2024
@mmahadevan108 mmahadevan108 self-assigned this Sep 20, 2024
@MaureenHelm MaureenHelm merged commit 4405420 into zephyrproject-rtos:main Sep 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants