wifi: Get RTS threshold #77774
Closed
wifi: Get RTS threshold #77774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add api to get rts threshold. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
Add api support to get RTS threshold. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
VivekUppunda
approved these changes
Sep 2, 2024
krish2718
approved these changes
Sep 11, 2024
sachinthegreen
requested changes
Sep 11, 2024
| return ret; | ||
| } | ||
|
|
||
| *rts_threshold = (int)vif_ctx_zep->rts_threshold_value; |
There was a problem hiding this comment.
If this is being cast to int then why not define the rts_threshold as int instead of unsigned int ?
| @@ -83,6 +83,7 @@ struct nrf_wifi_vif_ctx_zep { | |||
| #ifdef CONFIG_NRF_WIFI_RPU_RECOVERY | |||
| struct k_work nrf_wifi_rpu_recovery_work; | |||
| #endif /* CONFIG_NRF_WIFI_RPU_RECOVERY */ | |||
| unsigned int rts_threshold_value; | |||
There was a problem hiding this comment.
Why not define as int instead of unsigned int (see comment below in wifi_mgmt.c) ?
|
Need to close this, will update changes with proper branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add api support to get RTS threshold.