Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new non volatile storage system #77930

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

rghaddab
Copy link
Contributor

@rghaddab rghaddab commented Sep 3, 2024

Implements RFC #77929

This is the a new storage system that is designed especially to work on non erasable devices but supports as well erasable devices.

It is intended that some features described in the RFC are not implemented yet to make it easier to review for contributors that are familiar with NVS filesystem.

Already included feature :

  • Simple Key-Value Storage (i.e. no file/folder abstractions)
  • 32-bit IDs
  • Metadata entries can also store small (1 to 8 bytes) data entries
  • Support for no-erase-required flash drivers (i.e. RRAM, MRAM, etc)

Features in progress:

  • No limits in value length
  • Support for entries in multiple formats
  • CRC-24 for entries that require it (part of multiple format entries)
  • Efficiency for Settings subsystem
  • Efficiency for Secure Storage subsystem

@nordicjm nordicjm linked an issue Sep 4, 2024 that may be closed by this pull request
@butok
Copy link
Contributor

butok commented Sep 4, 2024

There is no a ZMS User Documentation.

@rghaddab
Copy link
Contributor Author

rghaddab commented Sep 4, 2024

There is no a ZMS User Documentation.

Yes there is no Documentation yet as this could change a lot from its initial proposal.
The PR is still in Draft mode and some work is still in Progress.
I will add some information about what is already included in this PR and what is coming next

@de-nordic de-nordic removed the DNM This PR should not be merged (Do Not Merge) label Oct 24, 2024
@fabiobaltieri fabiobaltieri merged commit 3c4fcaa into zephyrproject-rtos:main Oct 24, 2024
25 of 26 checks passed
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR: zephyrproject-rtos/zephyr#80402

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit c93c98eb20d21fccef17cb68beee63b7b0925ac8)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR: zephyrproject-rtos/zephyr#80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit c93c98eb20d21fccef17cb68beee63b7b0925ac8)
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR: zephyrproject-rtos/zephyr#80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit 494e0cff17dbccbd8093911f063fdd47e26b35eb)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 25, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR: zephyrproject-rtos/zephyr#80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit 494e0cff17dbccbd8093911f063fdd47e26b35eb)
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR #: 80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR #: 80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR #: 80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
rlubos pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR #: 80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
NordicBuilder pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 28, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR #: 80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
(cherry picked from commit 53f2704)
rlubos pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 29, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Upstream PR #: 80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
(cherry picked from commit 53f2704)
Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'm done! (Literally and also figuratively.)

subsys/fs/zms/Kconfig Show resolved Hide resolved
subsys/fs/zms/Kconfig Show resolved Hide resolved
subsys/fs/zms/Kconfig Show resolved Hide resolved
subsys/fs/zms/Kconfig Show resolved Hide resolved
subsys/fs/zms/Kconfig Show resolved Hide resolved
doc/services/storage/zms/zms.rst Show resolved Hide resolved
doc/services/storage/zms/zms.rst Show resolved Hide resolved
doc/services/storage/zms/zms.rst Show resolved Hide resolved
doc/services/storage/zms/zms.rst Show resolved Hide resolved
doc/services/storage/zms/zms.rst Show resolved Hide resolved
mmahadevan108 pushed a commit that referenced this pull request Oct 29, 2024
This resolves some addressed comments in this PR
#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 30, 2024
This resolves some addressed comments in this PR zephyrproject-rtos#77930
as well as this PR zephyrproject-rtos#80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 31, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
(cherry picked from commit 46e1635)
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Oct 31, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos/zephyr#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

(cherry picked from commit 46e1635)

Original-Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
GitOrigin-RevId: 46e1635
Cr-Build-Id: 8732568629207591185
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8732568629207591185
Copybot-Job-Name: zephyr-main-copybot-downstream
Change-Id: I8c7943abb79cb570bce4493db9eb5fd36616c29f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5982755
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
cooked pushed a commit to cooked/zephyr that referenced this pull request Nov 6, 2024
This resolves some addressed comments in this PR
zephyrproject-rtos#77930

It adds as well a section in the documentation about some
recommendations to increase ZMS performance.

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Nov 6, 2024
This resolves some addressed comments in this PR zephyrproject-rtos#77930
as well as this PR zephyrproject-rtos#80407

Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New non-volatile storage system