-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: hal_nxp: osa: Remove unused OSA API #77931
modules: hal_nxp: osa: Remove unused OSA API #77931
Conversation
Radimli
commented
Sep 3, 2024
- Deleted file fsl_os_abstraction.h is unused and deprecated
- Location of current OSA API available in modules/hal/nxp/mcux/mcux-sdk/components/osa
Hello @Radimli, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change- please take a look at your git
configuration. There are a few issues the compliance script is flagging (you can view these by clicking "Details" on the failed compliance check)
- Commit author does not match the
signed-off
entry: You can update the author of this commit withgit commit --amend --author "Radim.Lipka@nxp.com"
- Commit body is too long (>75 characters on one line)- just add a line break in the commit body to fix this, editors like vim will do this for you automatically
Edit: we will also need to look at the failing twister tests- these point to places where the OSA API might still be used. It looks like this PR has some USB sample build failures.
d1ce4ee
to
32bb66e
Compare
Hello @danieldegrasse, yes, cmake regarding USB MW should be modified. Already discussing it with @MarkWangChinese |
@danieldegrasse @MarkWangChinese |
Hi @Radimli You can update this PR (changing the west.yml) to contain the zephyrproject-rtos/hal_nxp#433 like: https://github.com/zephyrproject-rtos/zephyr/pull/77973/files#diff-d7f4082837dc3cb270fcf1abd68188216fdadee294e01611b8ca59ddea7fdbb3R201, then let the CI to check it. |
32bb66e
to
b2cf896
Compare
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
6a765b3
to
20fb957
Compare
Build tests look good, but you still have a compliance error. If you want to check this locally rather than waiting on CI (and are using Linux) you can run |
20fb957
to
d49f839
Compare
d49f839
to
67a5dab
Compare
Please address merge conflict when you get a chance |
67a5dab
to
078a36c
Compare
@Radimli ping to fix merge conflict |
078a36c
to
aa7fa39
Compare
@Radimli we are working to sequence the HAL PRs |
aa7fa39
to
446f157
Compare
New location of current OSA API available in /hal/nxp/mcux/mcux-sdk/components/osa Signed-off-by: Radim Lipka <Radim.Lipka@nxp.com>
80d8a4d
446f157
to
80d8a4d
Compare
@Radimli HAL side merged and this PR has been updated to point to the new SHA. |
d207ee9
into
zephyrproject-rtos:main
Hi @Radimli! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |