Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: hal_nxp: osa: Remove unused OSA API #77931

Merged

Conversation

Radimli
Copy link
Contributor

@Radimli Radimli commented Sep 3, 2024

  • Deleted file fsl_os_abstraction.h is unused and deprecated
  • Location of current OSA API available in modules/hal/nxp/mcux/mcux-sdk/components/osa

Copy link

github-actions bot commented Sep 3, 2024

Hello @Radimli, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change- please take a look at your git configuration. There are a few issues the compliance script is flagging (you can view these by clicking "Details" on the failed compliance check)

  • Commit author does not match the signed-off entry: You can update the author of this commit with git commit --amend --author "Radim.Lipka@nxp.com"
  • Commit body is too long (>75 characters on one line)- just add a line break in the commit body to fix this, editors like vim will do this for you automatically

Edit: we will also need to look at the failing twister tests- these point to places where the OSA API might still be used. It looks like this PR has some USB sample build failures.

@Radimli
Copy link
Contributor Author

Radimli commented Sep 5, 2024

Thanks for this change- please take a look at your git configuration. There are a few issues the compliance script is flagging (you can view these by clicking "Details" on the failed compliance check)

  • Commit author does not match the signed-off entry: You can update the author of this commit with git commit --amend --author "Radim.Lipka@nxp.com"
  • Commit body is too long (>75 characters on one line)- just add a line break in the commit body to fix this, editors like vim will do this for you automatically

Edit: we will also need to look at the failing twister tests- these point to places where the OSA API might still be used. It looks like this PR has some USB sample build failures.

Hello @danieldegrasse,

yes, cmake regarding USB MW should be modified. Already discussing it with @MarkWangChinese

@Radimli
Copy link
Contributor Author

Radimli commented Sep 5, 2024

@danieldegrasse @MarkWangChinese
It should be solved in
zephyrproject-rtos/hal_nxp#433

@MarkWangChinese
Copy link
Contributor

Hi @Radimli You can update this PR (changing the west.yml) to contain the zephyrproject-rtos/hal_nxp#433 like: https://github.com/zephyrproject-rtos/zephyr/pull/77973/files#diff-d7f4082837dc3cb270fcf1abd68188216fdadee294e01611b8ca59ddea7fdbb3R201, then let the CI to check it.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 5, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@78b3972 zephyrproject-rtos/hal_nxp@74a7735 (master) zephyrproject-rtos/hal_nxp@78b3972e..74a7735b

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Sep 5, 2024
west.yml Outdated Show resolved Hide resolved
@Radimli Radimli force-pushed the remove_osa_unused branch 4 times, most recently from 6a765b3 to 20fb957 Compare September 13, 2024 15:55
@danieldegrasse
Copy link
Collaborator

Build tests look good, but you still have a compliance error. If you want to check this locally rather than waiting on CI (and are using Linux) you can run ./scripts/ci/check_compliance.py -c $(git merge-base HEAD main)...HEAD from your zephyr repo, with this branch checked out.

danieldegrasse
danieldegrasse previously approved these changes Sep 16, 2024
dleach02
dleach02 previously approved these changes Sep 18, 2024
@danieldegrasse
Copy link
Collaborator

Please address merge conflict when you get a chance

danieldegrasse
danieldegrasse previously approved these changes Oct 3, 2024
@danieldegrasse
Copy link
Collaborator

@Radimli ping to fix merge conflict

dleach02
dleach02 previously approved these changes Oct 15, 2024
@dleach02
Copy link
Member

@Radimli we are working to sequence the HAL PRs

danieldegrasse
danieldegrasse previously approved these changes Oct 17, 2024
dleach02
dleach02 previously approved these changes Oct 22, 2024
New location of current OSA API available in
/hal/nxp/mcux/mcux-sdk/components/osa

Signed-off-by: Radim Lipka <Radim.Lipka@nxp.com>
@dleach02 dleach02 dismissed stale reviews from danieldegrasse and themself via 80d8a4d October 24, 2024 16:56
@dleach02
Copy link
Member

@Radimli HAL side merged and this PR has been updated to point to the new SHA.

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 24, 2024
@dleach02 dleach02 added this to the v4.0.0 milestone Oct 24, 2024
@henrikbrixandersen henrikbrixandersen merged commit d207ee9 into zephyrproject-rtos:main Oct 25, 2024
24 of 25 checks passed
Copy link

Hi @Radimli!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants