scripts: twister: Fix warnings & update some style (dependency injection/type hints). #77989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
gchwier,
golowanow,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
ithinuel
force-pushed
the
twister-pytests
branch
3 times, most recently
from
7c1b63b
to
ec8a7e5
Compare
|
@nashif Thank you for the thumb up. |
Space separated lists are deprecated but this notice is not checked for. extract_fields_from_arg_list also converts lists back to space-separated lists causing a warning on get_scenario Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
nashif
reviewed
Sep 11, 2024
nashif
previously approved these changes
Sep 11, 2024
golowanow
reviewed
Sep 11, 2024
| @@ -36,7 +36,7 @@ def extract_fields_from_arg_list(target_fields: set, arg_list: Union[str, list]) | |||
| # Move to other_fields | |||
| other_fields.append(field) | |||
|
|
|||
| return extracted_fields, " ".join(other_fields) | |||
| return extracted_fields, other_fields | |||
There was a problem hiding this comment.
i suspect get_scenario() needs modifications too, to align with the return type change here.
There was a problem hiding this comment.
As far as I can tell, extra_args is expected to be a list (in yaml) so returning it as a list seems ok to me.
I coulding find other places than test_twister that check for the content of this parameter explicitly. I may have missed some relevant location, could you point me to some of them please?
teburd
previously approved these changes
Sep 11, 2024
CONF_FILE, DTC_OVERLAY_FILE and OVERLAY_CONFIG are deprecated but still used by the tests causing warnings when running them. This adds a test_data specific to validate the emission of the warning, and removes the offending args from the other test_data files. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
Python 3.12 warns that
> Testing an element's truth value will raise an exception in future
> versions. Use specific 'len(elem)' or 'elem is not None' test instead.
> if elem_ts := root.find('testsuite'):
Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
Adjusting the type hints and code accordingly. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
This changes how some arguments are set in the `Handler`s. `options`, `generator_cmd` and `suite_name_check` are now passed as arguments to the constructor rather than injected from an other module. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
Twister main expects an instance of TwisterEnv. Let's the linter know about this. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
ithinuel
force-pushed
the
twister-pytests
branch
from
ec8a7e5
to
b61c5fc
Compare
nashif
approved these changes
Sep 12, 2024
teburd
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These change allow
ZEPHYR_BASE=$(pwd) PYTHON_PATH=./scripts/tests pytest ./scripts/tests/twisterto run locally from zephyr's directory to pass and do so without warning.Please refer to each commit messages for a short explanation of the related change.
I cannot get
ZEPHYR_BASE=$(pwd) PYTHON_PATH=./scripts/tests pytest ./scripts/tests/twister_blackboxto run locally but I lack the time to investigate what am I doing wrong.But it passes in CI :)