Intel: ADSP: move HPSRAM mask into assembly #78057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly in power_down() in power_down.S already defines data and code to be locked in cache when powering down SRAM. Instead of adding another such location in power.c, move the hpsram_mask[] array into power_down.S. This fixes hard to debug failures when shutting down the ADSP.
Yes, thesofproject/sof#9268 raises its ugly head again: https://sof-ci.01.org/sofpr/PR9430/build7664/devicetest/index.html We are no wiser about real reasons, but this is yet another attempt at a more robust fix